Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

=fix the issue #3524 #3543

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −2
Open

=fix the issue #3524 #3543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eba43e6
=fix the issue #3524
Made4Uo Jun 29, 2024
297e63b
Merge branch 'main' into change-product-image-zoom-size
Made4Uo Jul 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions assets/section-main-product.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,20 +620,28 @@ a.product__text {
.product-media-modal__dialog {
display: flex;
align-items: center;
height: 100vh;
height: 100%;
}

.product-media-modal__content {
max-height: 100vh;
max-height: 100%;
width: 100%;
overflow: auto;
padding-right: 5rem;
padding-left: 5rem;
}

.product-media-modal__content > *:not(.active),
.product__media-list .deferred-media {
display: none;
}

.product-media-modal__content .global-media-settings {
width: auto;
height: 90vh; /* Show preview of next image to let user know that this can be scrolled */
aspect-ratio: 1;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aspect-ratio-example
Shirt on left: aspect-ratio: 1;
Shirt on right: aspect-ratio: auto;

aspect-ratio: 1; is causing some images to become distorted when testing.

}

@media screen and (min-width: 750px) {
.product-media-modal__content {
padding-bottom: 2rem;
Expand All @@ -653,6 +661,12 @@ a.product__text {
}

@media screen and (max-width: 749px) {
.product-media-modal__content .global-media-settings {
width: 100%;
height: auto;
aspect-ratio: 1;
}

.product--thumbnail .is-active .product__modal-opener:not(.product__modal-opener--image),
.product--thumbnail_slider .is-active .product__modal-opener:not(.product__modal-opener--image) {
display: none;
Expand Down
Loading