Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement file cache #191

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

ChrisBr
Copy link

@ChrisBr ChrisBr commented Nov 4, 2020

First approach to implement a file cache.

  • Implement functionality to prune cache
  • Add error message when using --with-cache and `--autocorrect`` options together
  • Implement specs

#158

Co-authored-by: Mike Dalessio mike.dalessio@gmail.com

First approach to implement a file cache.

#158

Co-authored-by: Mike Dalessio <mike.dalessio@gmail.com>
@ChrisBr ChrisBr force-pushed the cbruckmayer/implement-file-cache branch from f06c406 to 5db0880 Compare November 4, 2020 18:11
@zachfeldman
Copy link

@ChrisBr @flavorjones hi 👋 ! I was thinking of picking this work back up and trying to get something merged around this again. It would really help lower the time of our linting step locally!

Were there any particular road blocks around getting this solution merged? I tried running it locally and it seemed to skip files on cache hits, so I suppose that's half the battle. Just wondering if ya'll remember hitting some insurmountable challenge trying to write this PR or other priorities took over.

@ChrisBr
Copy link
Author

ChrisBr commented Aug 8, 2022

@zachfeldman no particular roadblocks just some work left todo

  • Implement functionality to prune cache
  • Add error message when using --with-cache and --autocorrect options together
  • Implement specs

Feel free to pick this up and finish it.

@zachfeldman
Copy link

Got started today with a pruning commit that seems to work with my experiments:
7496dbb

will continue and try to get the rest of the checklist! I think I'll also add a clear command in addition to clean (which I should just rename prune).

@zachfeldman
Copy link

@ChrisBr @flavorjones opened up a PR with the requirements and a bit more along with specs:
#268

definitely appreciate any feedback on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants