Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't try to autocorrect linters that don't support autocorrect #264

Merged
merged 1 commit into from
Jul 27, 2022
Merged

Don't try to autocorrect linters that don't support autocorrect #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/erb_lint/corrector.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def initialize(processed_source, offenses)

def corrections
@corrections ||= @offenses.map do |offense|
offense.linter.autocorrect(@processed_source, offense)
offense.linter.autocorrect(@processed_source, offense) if offense.linter.class.support_autocorrect?
end.compact
end

Expand Down
4 changes: 2 additions & 2 deletions spec/erb_lint/cli_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,9 +514,9 @@ def run(processed_source)
end

context "when autocorrecting an error" do
# We assume that linter_without_errors is not autocorrectable...
# We assume that linter_with_errors is not autocorrectable...
let(:args) do
["--enable-linter", "final_newline,linter_without_errors", "--stdin", linted_file, "--autocorrect"]
["--enable-linter", "final_newline,linter_with_errors", "--stdin", linted_file, "--autocorrect"]
end

it "tells the user it is autocorrecting" do
Expand Down