Use a stricter import order

Force the order to be builtin, external, internal, parent, sibling instead of allowing intermingling.
Shopify · Oct 25, 2018 · 1196748 · 1196748
1 parent 0eb4948
commit 1196748
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,7 @@
 ### Changed
 
 * Updated `plugin:shopify/prettier`, `plugin:shopify/react`, and `plugin:shopify/typescript` to use `overrides` ([#173](https://github.com/Shopify/eslint-plugin-shopify/pull/173))
+* Update `import/order` rule to enforce ordering of internal, parent and sibling imports ([#189](https://github.com/Shopify/eslint-plugin-shopify/pull/189))
 
 ## [25.1.0] - 2018-10-01
 

diff --git a/lib/config/rules/import.js b/lib/config/rules/import.js
@@ -90,7 +90,7 @@ module.exports = {
   'import/order': [
     'error',
     {
-      groups: [['builtin', 'external'], ['internal', 'parent', 'sibling']],
+      groups: ['builtin', 'external', 'internal', 'parent', 'sibling'],
     },
   ],
   // Enforce a newline after import statements