clean up

lib/rules/strict-component-boundaries.js

@@ -16,11 +16,12 @@ module.exports = {
     return {
       ImportDeclaration(node) {
         const importSource = node.source.value;
-        const pathParts = importSource
-          .split('/')
-          .filter((part) => part[0] !== '.');
+        const resolvedSource = resolve(importSource, context);
+        const pathParts = resolvedSource
+          ? pathSegmantsFromSource(resolvedSource)
+          : pathSegmantsFromSource(importSource);
 
-        if (inNodeModules(importSource, context)) {
+        if (isCoreModule(resolvedSource) || inNodeModules(pathParts)) {
           return;
         }
 
@@ -38,18 +39,12 @@ module.exports = {
   },
 };
 
-function inNodeModules(importSource, context) {
-  const resolvedSource = resolve(importSource, context);
-
-  if (resolvedSource === null) {
-    return true;
-  }
-
-  if (!resolvedSource) {
-    return false;
-  }
+function isCoreModule(resolvedSource) {
+  return resolvedSource === null;
+}
 
-  return resolvedSource.match(/node_modules/);
+function inNodeModules(pathParts) {
+  return Boolean(pathParts.filter((part) => part === 'node_modules').length);
 }
 
 function hasComponentDirectoryInPath(pathParts) {
@@ -59,3 +54,7 @@ function hasComponentDirectoryInPath(pathParts) {
 function hasAnotherComponentInPath(pathParts) {
   return Boolean(pathParts.filter((part) => part === pascalCase(part)).length);
 }
+
+function pathSegmantsFromSource(source) {
+  return source.split('/').filter((part) => part[0] !== '.');
+}

tests/lib/rules/strict-component-boundaries.js

@@ -1,4 +1,5 @@
 const {RuleTester} = require('eslint');
+const {fixtureFile} = require('../../utilities');
 const rule = require('../../../lib/rules/strict-component-boundaries');
 
 const ruleTester = new RuleTester();
@@ -26,12 +27,9 @@ ruleTester.run('strict-component-boundaries', rule, {
       parserOptions,
     },
     {
-      code: `import fs from 'fs';`,
-      parserOptions,
-    },
-    {
-      code: `import eslint from 'eslint';`,
+      code: `import {getDisplayName} from '@shopify/react-utilities/components';`,
       parserOptions,
+      filename: fixtureFile('basic-app/app/sections/MySection/MySection.js'),
     },
   ],
   invalid: [