adds `react-no-render-methods’ rule

lib/rules/react-no-render-methods.js

@@ -0,0 +1,46 @@
+const Components = require('eslint-plugin-react/lib/util/Components');
+
+module.exports = {
+  meta: {
+    docs: {
+      description: 'Disallow public members within React component classes',
+      category: 'Best Practices',
+      recommended: true,
+      uri:
+        'https://github.com/Shopify/eslint-plugin-shopify/blob/master/docs/rules/react-prefer-private-members.md',
+    },
+  },
+
+  create: Components.detect((context, components, utils) => {
+    let isES6Component = false;
+
+    function report(node) {
+      const {
+        key: {name},
+      } = node;
+
+      context.report({
+        node,
+        message: `No renderX methods. '{{name}}' should be a seperate component.`,
+        data: {name},
+      });
+    }
+
+    return {
+      ClassDeclaration(node) {
+        isES6Component = utils.isES6Component(node);
+      },
+      MethodDefinition(node) {
+        if (!isES6Component || isRenderMethod(node)) {
+          return;
+        }
+
+        report(node);
+      },
+    };
+  }),
+};
+
+function isRenderMethod({key: {name}}) {
+  return !name.match(/^render[a-zA-Z0-9]+/i);
+}

tests/lib/rules/react-no-render-methods.js

@@ -0,0 +1,35 @@
+const {RuleTester} = require('eslint');
+const rule = require('../../../lib/rules/react-no-render-methods');
+
+const ruleTester = new RuleTester();
+
+require('babel-eslint');
+
+const babelParser = 'babel-eslint';
+
+function error(memberName) {
+  return {
+    type: 'MethodDefinition',
+    message: `No renderX methods. '${memberName}' should be a seperate component.`,
+  };
+}
+
+ruleTester.run('react-no-render-methods', rule, {
+  valid: [
+    {
+      code: `class Button extends React.Component {
+        render() {}
+      }`,
+      parser: babelParser,
+    },
+  ],
+  invalid: [
+    {
+      code: `class Button extends React.Component {
+        renderFoo() {}
+      }`,
+      parser: babelParser,
+      errors: [error('renderFoo')],
+    },
+  ],
+});