Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Add lint rule for "what do I return from a hook?" #234

Closed
lemonmade opened this issue Apr 2, 2019 · 2 comments · Fixed by #237
Closed

Add lint rule for "what do I return from a hook?" #234

lemonmade opened this issue Apr 2, 2019 · 2 comments · Fixed by #237
Assignees
@cartogram
Labels
enhancement

Comments

@lemonmade
Copy link
Member

lemonmade commented Apr 2, 2019 •
edited
Loading

Or, just a best practice guide, if we can't do a linting rule.
@lemonmade lemonmade changed the title Document/ add lint rule for "what do I return from a hook?" Add lint rule for "what do I return from a hook?" Apr 2, 2019
@cartogram
Copy link
Contributor

cartogram commented Apr 6, 2019 •
edited
Loading

Just a start, but here is a basic check for max 'things' returned.
https://astexplorer.net/#/gist/b015f5cd1b41b049f2feffdff6d9f3a9/a616e30f1d02733e274d6c96133d285c6450ecec
Could build on this to limit returning only objects or only arrays under certain circumstances.

@cartogram
Copy link
Contributor

https://astexplorer.net/#/gist/b015f5cd1b41b049f2feffdff6d9f3a9/2d1b13e4e01e1a2d90b6b2b4168793f1f3a2953a

@cartogram cartogram self-assigned this Apr 12, 2019
@cartogram cartogram mentioned this issue Apr 12, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cartogram cartogram

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds hooks-strict-return Shopify/eslint-plugin-shopify
2 participants
@cartogram @lemonmade