This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Adds hooks-strict-return
#237
Merged
+438
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lemonmade @GoodForOneFare @michelleyschen @TheMallen Can I get some initial feedback on this rule? Is this what we want to enforce? Anything I am missing? Worth noting that I am not looking to get this to the point where it will know everything about what you are returning. For example, if the variables you are returning are the result of a function call or from another file. |
|
I am board with this 👍 |
cartogram
force-pushed
the
hooks-strict-return
branch
from
c3469da
to
4b55868
Compare
lemonmade
approved these changes
Apr 17, 2019
| return; | ||
| } | ||
|
|
||
| inHook = false; |
There was a problem hiding this comment.
I suspect something like this will cause the rule to not complain, even though it should:
function useFoo() {
useEffect(() => {});
return [1, 2, 3, 4];
}There was a problem hiding this comment.
Added some more tests to cover this https://github.com/Shopify/eslint-plugin-shopify/pull/237/files#diff-cde867597099df6969da77e4a149d359R206
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #234