-
Notifications
You must be signed in to change notification settings - Fork 18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Aside from the file renames, I don't feel strongly about any other comments.
@@ -0,0 +1,33 @@ | |||
# Enforce pascal case when naming enums. (prefer-pascal-case-enums) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be a file rename. I still see docs/rules/prefer-pascal-case-enums.md
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like fully namespacing the rule name because I tend to copy+paste the names from here into package.json#eslintConfig
.
So (shopify/typescript/prefer-pascal-case-enums)
would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Pascal is a noun, so pascal case
=> Pascal case
🤓
README.md
Outdated
@@ -136,6 +134,8 @@ This plugin provides the following custom rules, which are included as appropria | |||
- [sinon-no-restricted-features](docs/rules/sinon-no-restricted-features.md): Restrict the use of specified sinon features. | |||
- [sinon-prefer-meaningful-assertions](docs/rules/sinon-prefer-meaningful-assertions.md): Require the use of meaningful sinon assertions through sinon.assert or sinon-chai. | |||
- [strict-component-boundaries](docs/rules/strict-component-boundaries.md): Prevent module imports between components. | |||
- [typescipt/prefer-pascal-case-enums](docs/rules/typescipt/prefer-pascal-case-enums.md): Prefer TypeScript enums be defined using pascal case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mention rule renames in CHANGELOG.
@@ -0,0 +1,31 @@ | |||
# Prefer singular TypeScript enums. (prefer-singular-enums) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(shopify/typescript/prefer-singular-enums)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be a file rename. I'll stop mentioning that, now.
eab32ae
to
8bf1930
Compare
closes #136