This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Remove describe from jest/no-if
#235
Merged
+43
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartogram
commented
Apr 9, 2019
| } = require('../../utilities/jest'); | ||
| const {getTestMethodName} = require('../../utilities/jest'); | ||
|
|
||
| const TEST_FUNCTION_NAMES = ['it', 'xit', 'fit', 'test', 'xtest']; |
There was a problem hiding this comment.
I think the clearest thing is to just redefine these locally for this test.
cartogram
commented
Apr 9, 2019
| @@ -1761,13 +1761,6 @@ eslint-plugin-jsx-a11y@6.2.1: | |||
| has "^1.0.3" | |||
| jsx-ast-utils "^2.0.1" | |||
|
|
|||
| eslint-plugin-lodash@5.1.0: | |||
There was a problem hiding this comment.
This is a mistake leftover from a previous pr.
patsissons
approved these changes
Apr 9, 2019
tests/lib/rules/jest/no-if.js
Outdated
| })`, | ||
| code: `fit('foo', () => { | ||
| if('bar') {} | ||
| })`, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Removes
describefrom the checked function names ofjest/no-if.I tested this rule out in a few projects and if statements in afterEach/ beforeEach blocks and in general within
describeblocks is a valid thing to do.