This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Fixes shopify/jest/no-if to now ignore if statements inside block statements
#299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemonmade
reviewed
Jun 10, 2019
cartogram
force-pushed
the
no-if-nested-blocks
branch
3 times, most recently
from
792ce70
to
ddef4c8
Compare
lemonmade
suggested changes
Jun 12, 2019
cartogram
force-pushed
the
no-if-nested-blocks
branch
from
ddef4c8
to
2cc18bd
Compare
|
@lemonmade ready for another look |
lemonmade
approved these changes
Jun 17, 2019
| 'each fork in the conditional statement.', | ||
| 'If your conditionals are required to', | ||
| 'satisfy the typescript type checker, consider', | ||
| 'using a non-null assertion operator (!) instead.', |
lib/rules/jest/no-if.js
Outdated
| return; | ||
| } | ||
|
|
||
| if (isTestDefinition(lastCallExpression)) { |
There was a problem hiding this comment.
Is there a reason to compute this manually every time? Can the stack just have the results of calling this?
cartogram
force-pushed
the
no-if-nested-blocks
branch
from
cfe79a7
to
5e99fdd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #263