Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Enable import/no-namespace #305

Merged
merged 1 commit into from
Jun 17, 2019
Merged

Enable import/no-namespace #305

merged 1 commit into from
Jun 17, 2019

Conversation

cartogram
Copy link
Contributor

@cartogram cartogram commented Jun 17, 2019

After going through the process of writing a first-party, opinionated version of this rule, I have settled upon just using the third-party rule from eslint-plugin-import instead.

Copy link
Member

@GoodForOneFare GoodForOneFare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Off the top of my head, a couple of libs in web needed namespaced imports, but that's what eslint-disable is for.

@cartogram cartogram merged commit 0a6fedb into master Jun 17, 2019
@cartogram cartogram deleted the enable-no-namespace branch June 17, 2019 19:06
cartogram pushed a commit that referenced this pull request Jun 18, 2019
cartogram pushed a commit that referenced this pull request Jun 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants