This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enforces a new line between import groups, from this rule: https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/order.md#newlines-between-ignorealwaysalways-and-inside-groupsnever
The reason I chose this approach is because it enforces what looks to be the side our codebase leans towards:
The effect of running with
always
(caps at 999)The effect of running with
never
With the addition of this rule the following are true:
Invalid
Valid
I attempted to see what this rule would cause if I also ran
--fix
on web, and this was the result:https://github.com/Shopify/web/pull/18382