This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Use word boundaries for vague terms separation #514
Merged
+32
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
no-vague-titles
rule on test statements is perhaps too general.For most keywords, the rule matches sequences instead of words.
Example
If I use a variable that contains a blacklisted word like
someVariableWithEveryInIt
in my title , I get ano-vague-titles
error because of every, even though I technically did not use the word every in my title.Fix
Change the regular expressions to match words instead of sequences.
Instead of checking if the test statement contains a sequence, use regex's word boundaries to check if the string contains a word.