This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Adding a typescript & typescript-react config #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismail-syed
changed the title
ismail-syed
commented
Dec 1, 2017
| strict: 'off', | ||
| 'shopify/prefer-early-return': 'off', | ||
| 'array-callback-return': 'off', | ||
| 'getter-return': 'off', |
There was a problem hiding this comment.
This config still uses the stock typescript-eslint-parser. The workaround attempts to address these 4 rules revealed more concerns with the parser.
The performance improvements of using eslint vs tslint easily outweigh loosing these 4 rules.
ismail-syed
commented
Dec 1, 2017
| 'react/default-props-match-prop-types': 'off', | ||
|
|
||
| // Breaks typescript-eslint-parser | ||
| 'react/jsx-indent': 'off', |
There was a problem hiding this comment.
It sucks that the fixers for these rules break the parser, but using the prettier config with the parser option set to typescript gives us the features back.
lemonmade
approved these changes
Dec 1, 2017
ismail-syed
force-pushed
the
typescript-config
branch
from
1fac4dd
to
16c34af
Compare
ismail-syed
force-pushed
the
typescript-config
branch
from
e1ddbab
to
9c2e361
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a consumable typescript & typescriptReact config for projects with .ts and .tsx files.
The application of the
typescriptconfig is demonstrated in sewing-kit in hereThis is a revive of #42