This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Add react-prefer-private-members rule
#95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartogram
changed the title
react-prefer-private-members rulereact-prefer-private-members rule
cartogram
commented
May 20, 2018
| meta: { | ||
| docs: { | ||
| description: 'Disallow public members within React component classes', | ||
| category: 'Possible Errors', |
There was a problem hiding this comment.
Not really sure what to put in here. Just did my best to follow other rules in this repo.
| docs: { | ||
| description: 'Disallow public members within React component classes', | ||
| category: 'Possible Errors', | ||
| recommended: true, |
lemonmade
approved these changes
May 21, 2018
| meta: { | ||
| docs: { | ||
| description: 'Disallow public members within React component classes', | ||
| category: 'Possible Errors', |
| } = node; | ||
| return { | ||
| node, | ||
| message: `${name} should be a private member of ${componentName}.`, |
There was a problem hiding this comment.
You don't need to pass the variables?
| ].some((method) => method === name); | ||
| } | ||
|
|
||
| function isReactStaticProperty({key: {name}}) { |
There was a problem hiding this comment.
I think you probably want to allow all static properties, or at least those that are pascal-case, to allow for our (pretty common) pattern of exposing subcomponent as public static members.
| parser: babelParser, | ||
| }, | ||
| ], | ||
| invalid: [ |
There was a problem hiding this comment.
Need more tests than this (missing for private members, static members, etc
cartogram
force-pushed
the
react-prefer-private-members
branch
from
30510a3
to
d5866f3
Compare
added 2 commits
June 2, 2018 15:12
cartogram
force-pushed
the
react-prefer-private-members
branch
from
d5866f3
to
21378e0
Compare
|
@lemonmade this is ready for another look. 🙏 |
lemonmade
approved these changes
Jun 3, 2018
| } | ||
| ``` | ||
|
|
||
| The Life Cycle methods and static properties that are part of the React API are not required to be private for this rule. |
| ``` | ||
|
|
||
|
|
||
|
|
cartogram
force-pushed
the
react-prefer-private-members
branch
from
1f732c2
to
db33276
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses one of the points here #77 by looking for React class components and making sure they do not have private members. React API stuff will pass through. Will fill in the docs once the general approach is approved.