Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Sub in a ReadableStream polyfill for Node environments #519

Closed
jplhomer opened this issue Jan 24, 2022 · 3 comments · Fixed by #527
Closed

[BUG] Sub in a ReadableStream polyfill for Node environments #519

jplhomer opened this issue Jan 24, 2022 · 3 comments · Fixed by #527
Labels
bug Something isn't working framework Related to framework aspects of Hydrogen

Comments

@jplhomer
Copy link
Contributor

Describe the bug
This made it in with #317 but we should swap out node/streams with a ReadableStream polyfill in Node.js runtimes.

This is because Node 16 is not yet supported in StackBlitz.
@jplhomer jplhomer added bug Something isn't working framework Related to framework aspects of Hydrogen labels Jan 24, 2022
@blittle
Copy link
Contributor

blittle commented Jan 24, 2022

How much effort should we put into this? cc @morganmccunn?

@jplhomer
Copy link
Contributor Author

Oh I was assuming this would be a one-liner to replace

https://github.com/Shopify/hydrogen/blob/daf164ef8aaf3e9d86653bc8ada088991eb67c19/packages/hydrogen/src/framework/middleware.ts#L79

with

https://github.com/MattiasBuelens/web-streams-polyfill

@blittle
Copy link
Contributor

blittle commented Jan 24, 2022

I think it will be more work for the API Routes streaming implementation. But I guess it might not be too bad.

@jplhomer jplhomer mentioned this issue Jan 24, 2022
Merged
rafaelstz pushed a commit to rafaelstz/hydrogen that referenced this issue Mar 4, 2023
@frandiox
Add unit test for check-lockfile (Shopify#519)
b5e9061 
* Add unit test for check-lockfile

* Update packages/cli/src/utils/check-lockfile.test.ts

Co-authored-by: Matt Seccafien <matt.seccafien@shopify.com>

---------

Co-authored-by: Matt Seccafien <matt.seccafien@shopify.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working framework Related to framework aspects of Hydrogen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use web streams polyfill in Node middleware so we can support Node v14 Shopify/hydrogen-v1
2 participants
@jplhomer @blittle