Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: clear default render cache after timeout #424

Closed
wants to merge 1 commit into from
Closed

feat: clear default render cache after timeout #424

wants to merge 1 commit into from

Conversation

wizardlyhel
Copy link
Collaborator

Description

Fix: Shopify/hydrogen#415

Before submitting the PR, please make sure you do the following:

  • Add your change under the Unreleased heading in the package's CHANGELOG.md
  • Read the Contributing Guidelines
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
  • Update docs in this repository for your change, if needed

@wizardlyhel wizardlyhel requested review from frandiox and a team January 6, 2022 20:31
@wizardlyhel
Copy link
Collaborator Author

@frandiox @jplhomer I don't know if this is necessary to periodically clean out the default rendering cache

It behaves like this

Screen Shot 2022-01-06 at 12 35 22 PM

@wizardlyhel
Copy link
Collaborator Author

This might be a React 18 bug facebook/react#23089

@wizardlyhel wizardlyhel deleted the render-cache-clear branch February 24, 2022 19:29
@cartogram cartogram mentioned this pull request Mar 4, 2022
Closed
6 tasks
rafaelstz pushed a commit to rafaelstz/hydrogen that referenced this pull request Mar 4, 2023
@jplhomer
Merge pull request Shopify#424 from Shopify/changeset-release/2023-01
71de9e2 
[ci] release 2023-01 (alpha)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frandiox frandiox Awaiting requested review from frandiox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Render cache is reset when handling multiple requests at the same time
1 participant
@wizardlyhel