Fix Hydration errors #907
Closed
Fix Hydration errors #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
blittle
reviewed
Mar 14, 2022
There was a problem hiding this comment.
Why doesn't it also need it here? https://github.com/Shopify/hydrogen/blob/v1.x-2022-07/packages/hydrogen/src/foundation/Route/Route.server.tsx#L41
|
It does! Great catch. |
blittle
approved these changes
Mar 14, 2022
|
Closing since we fixed this with new suspense boundaries in #758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're noticing Hydration errors on most pages in Hydrogen's default template during initial page load.
Adding a Suspense boundary around server components which suspense that are passed as children to client components fixes the issue.
We're not sure if this is the expected behavior, but we're going to investigate with a smaller test case and potentially report it as a bug.