Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a pagination bug on country change #317

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Fix a pagination bug on country change #317

merged 1 commit into from
Dec 9, 2022

Conversation

wizardlyhel
Copy link
Contributor

How to reproduce:

  1. Go to /products page
  2. Scroll to the bottom and see infinite scroll is triggered
  3. Change country

Error generated:

Screenshot 2022-12-08 at 3 44 13 PM

@wizardlyhel wizardlyhel requested a review from cartogram December 8, 2022 23:45
@wizardlyhel wizardlyhel merged commit d2e11a9 into v0.x-2022-10 Dec 9, 2022
@wizardlyhel wizardlyhel deleted the hl-fix-pagination-bug branch December 9, 2022 16:58
@github-actions github-actions bot mentioned this pull request Dec 9, 2022
Merged
@github-actions github-actions bot mentioned this pull request Feb 8, 2023
Merged
@frandiox frandiox mentioned this pull request Jun 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartogram cartogram cartogram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wizardlyhel @cartogram