This repository has been archived by the owner on Apr 27, 2021. It is now read-only.
[WIP] EWMA improvements #219
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElvinEfendi
commented
Jun 28, 2019
| if slow_start_ewma < ewma then | ||
| slow_start_ewma = ewma | ||
| end | ||
| end |
There was a problem hiding this comment.
Not sure whether this is the best heuristic. Maybe 75th percentile value would be better?
ElvinEfendi
commented
Jun 28, 2019
| local slow_start_ewma = 0 | ||
| for _, endpoint in pairs(self.peers) do | ||
| local endpoint_string = endpoint.address .. ":" .. endpoint.port | ||
| local ewma = ngx.shared.balancer_ewma:get(endpoint_string) or 0 |
There was a problem hiding this comment.
Should probably use get_or_update_ewma to get decayed value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Proof of concept for now.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: