Scripts to create/rename transforms #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const utils = require('./transform-management-utils'); | ||
|
|
||
| function createFileSync(filePath, content) { | ||
| const fd = fs.openSync(filePath, 'wx'); |
There was a problem hiding this comment.
Why do you need to open it before writing? I always just write, am I a bad person?
There was a problem hiding this comment.
It's weird because I write directly to file in the rename helper. Who knows what I was thinking? Fixed now.
|
Minor comments, thanks for the utilities :) additions to the README might be nice too, unless I just missed them. |
GoodForOneFare
force-pushed
the
transform_cli
branch
from
ab15bf8
to
0757297
Compare
|
NPM ignored, file writes fixed, README updated. Thanks, @lemonmade! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have made my life easier, so I thought I'd share. If they're not useful, I'll keep them in my .gitignore :)
bin/create-transform my-neato-transform- creates a transform, test file, andbasicfixture filesbin/rename-transform my-neato-transform my-coolio-transform- renames the transform, test, and fixture dir/cc @lemonmade, @Fandy