Add rename-identifier and rename-property #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| export default function renameProperty({source}, {jscodeshift: j}, {printOptions = {quote: 'single'}, renameProperties = {}}) { | ||
| function hasPropertyThatShouldBeRenamed({node: {computed, object, property}}) { | ||
| return !computed && renameProperties[object.name].hasOwnProperty(property.name); |
There was a problem hiding this comment.
Could you add a sanity test for the !computed, please?
There was a problem hiding this comment.
I think _[each]() tests this, does it not?
There was a problem hiding this comment.
It sure does! Ignore me :)
|
Nice and concise! Looks great 👍 🚢 It looks like we don't have to worry about translating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102 and #126. This PR adds two new transforms,
rename-identifierandrename-property, to handle arbitrary renaming of identifiers and member expressions, respectively.cc/ @GoodForOneFare @Fandy