Minor improvements from a few more translation examples #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| d3: 'd3', | ||
| NProgress: 'NProgress', | ||
| FastClick: 'shopify-fastclick', | ||
| Clipboard: 'clipboard', |
|
👌 |
| @@ -12,6 +12,29 @@ This repository contains a collection of Codemods written with [JSCodeshift](htt | |||
|
|
|||
| ## Included Transforms | |||
|
|
|||
| ### `global-identifer-to-import` | |||
|
|
|||
| Transforms global identifiers that you specify into the appropriate import statements. In order for this to work, you must set the `globalIdentifiers` option to an object where the keys are the names of globals used in your script, and the keys are the import paths for those globals. | |||
There was a problem hiding this comment.
Transforms global identifiers seems misleading because this is an additive operation.
-the keys are the import paths
+the values are the import pathOverall, it could be more concise. Creates import statements for global references. Use the globalIdentifiers option to specify identifier/import path pairs.
|
Really nice stuff. Once the key=>value typo is fixed, this is good to 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few small things, I can unbundle them if it will make it easier to review:
global-identifier-to-importto turn globals (lodash, jQuery, etc) into import statements.remove-useless-return-from-testalso remove the IIFE wrapper from the return argument, if present. This was causing some issues with the transforms that depend on scope to do things, like the mocha ones. The bare IIFE also doesn't really make much sense, it's mostly just used for CoffeeScript's everything-is-an-expression madness.cc/ @GoodForOneFare @bouk @Fandy