Update all dependencies #93
Conversation
|
Oh, also locked down the dependency versions for |
|
Also killed the generator package because it's more trouble than it's worth and I didn't want to fix the tests :P |
| @@ -88,7 +88,9 @@ module.exports = { | |||
| // Disallow whitespace before properties | |||
| 'no-whitespace-before-property': 'error', | |||
| // Require or disallow padding inside curly braces | |||
| 'object-curly-spacing': 'off', | |||
| 'object-curly-spacing': ['warn', 'never'], | |||
There was a problem hiding this comment.
This is the opposite of our Ruby style. Will this cause unnecessary friction?
There was a problem hiding this comment.
I was just bringing this in line with our actual recommendation, good catch that it doesn't match the Ruby recommendation. I think there is reason enough to have this difference — since JS blocks are denoted with braces, it is helpful to have a different brace style between objects and functions to differentiate them. Ruby doesn't have this problem since any multiline block is usually not brace-delimited, and manipulating hashes is probably less common than in JS. Also, JS's destructuring, especially in parameters, means that the extra space inside of braces ends up making things quite a bit harder to read.
|
LGTM 👍 Thanks for staying on top of all of these rules and dependencies! |
This PR bumps versions on everything, adding a bunch of new rules.
cc/ @bouk @GoodForOneFare