Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix count_rows_in_file for ruby 2.6.3 #38

Merged
merged 3 commits into from
Jul 24, 2019
Merged

Fix count_rows_in_file for ruby 2.6.3 #38

merged 3 commits into from
Jul 24, 2019

Conversation

peterzhu2118
Copy link
Member

CSV#path was added to Ruby 2.6.3 and returns nil when the path of the CSV does not exist (instead of raising a NoMethodError). Ran into an issue where this method was returning -1 in 2.6.3 when the path was nil.

Also bumps the patch version.

rafaelfranca
rafaelfranca reviewed Jul 24, 2019
View reviewed changes
lib/job-iteration/csv_enumerator.rb Outdated Show resolved Hide resolved
lib/job-iteration/csv_enumerator.rb Outdated Show resolved Hide resolved
@peterzhu2118 peterzhu2118 merged commit 1cadfd0 into master Jul 24, 2019
@peterzhu2118 peterzhu2118 deleted the fix-count-rows-in-file-for-ruby-26 branch July 24, 2019 20:25
@peterzhu2118 peterzhu2118 temporarily deployed to rubygems July 24, 2019 20:27 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XrXr XrXr XrXr approved these changes

@rafaelfranca rafaelfranca rafaelfranca approved these changes

@kirs kirs Awaiting requested review from kirs

@GustavoCaso GustavoCaso Awaiting requested review from GustavoCaso

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterzhu2118 @rafaelfranca @XrXr