store constant index in instruction #155

ggmichaelgo · 2021-09-02T03:17:31Z

What are you trying to accomplish?

Main issue: #84

In order for us to implement If tag and For tag in Liquid-C, we need to be able to freely travel the instruction pointer.
Currently, Liquid-C uses an instruction pointer and a constants pointer, and this PR will remove the constants pointer.

What approach did you choose and why?

Currently, the instruction row is structured like this:

With this refactor, we will be storing the constant's index value in the instruction:

** We need to keep our instruction to be or below 24 bit in order to store compiled Liquid template in storage services.

Performance Improvement on simple rendering

With this refactor, we are seeing a no-speed improvement with simple benchmark testing. (gist link)

main branch

Warming up --------------------------------------
       render_liquid   289.000  i/100ms
   render_liquid_pre   332.000  i/100ms
Calculating -------------------------------------
       render_liquid      2.924k (± 0.5%) i/s -     14.739k in   5.039984s
   render_liquid_pre      3.276k (± 0.7%) i/s -     16.600k in   5.067964s

PR branch

Warming up --------------------------------------
       render_liquid   297.000  i/100ms
   render_liquid_pre   334.000  i/100ms
Calculating -------------------------------------
       render_liquid      2.959k (± 0.3%) i/s -     14.850k in   5.018144s
   render_liquid_pre      3.305k (± 0.7%) i/s -     16.700k in   5.053282s

Affect on Performance

While parsing, we will be storing the constant's index value into constants_table, therefore we won't be storing duplicate values in the constants array.
With this change, we are looking up and inserting value to a hashtable while vm_assembler_write_ruby_constant.

This will slightly affect our parsing time:

Before:

/home/michael/.rvm/rubies/ruby-3.0.2/bin/ruby ./performance.rb c benchmark lax

Running benchmark for 10 seconds (with 5 seconds warmup).

Warming up --------------------------------------
              parse:    10.000  i/100ms
             render:    17.000  i/100ms
     parse & render:     5.000  i/100ms
Calculating -------------------------------------
              parse:     92.906  (± 1.1%) i/s -    930.000  in  10.010951s
             render:    172.139  (± 1.2%) i/s -      1.734k in  10.074941s
     parse & render:     56.965  (± 0.0%) i/s -    570.000  in  10.006306s

Performance side-effect:

/home/michael/.rvm/rubies/ruby-3.0.2/bin/ruby ./performance.rb c benchmark lax

Running benchmark for 10 seconds (with 5 seconds warmup).

Warming up --------------------------------------
              parse:     9.000  i/100ms
             render:    17.000  i/100ms
     parse & render:     5.000  i/100ms
Calculating -------------------------------------
              parse:     87.346  (± 1.1%) i/s -    882.000  in  10.098912s
             render:    170.742  (± 1.2%) i/s -      1.717k in  10.057790s
     parse & render:     54.575  (± 0.0%) i/s -    550.000  in  10.078152s

Notes:
Ops to update to use constant index over constant pointer:

TODO:

Remove const_ptr
Fix constants and constants_table getting out of sync (this was happening when variable_strict_parse_rescue rolling back constants array)

macournoyer

WOWOWOWOW! THIS IS AMAZING @ggmichaelgo 🔥 🤯 🔥

I have a couple comments/questions. But the OP_FILTER num_args looks like a blocker to me (which is why I marked as "Request changes").

I still need to wrap my head around the assembler merging logic (vm_assembler_concat), I didn't know about that.

But overall... This is awesome!

(Did I mention this is amazing?)

macournoyer · 2021-10-20T13:40:05Z

ext/liquid_c/vm.c

+        if (vm_assembler_opcode_has_constant(*ip)) {
+            uint16_t constant_index = (ip[1] << 8) | ip[2];
+            constant = constants[constant_index];
+        }
+


This is a hot spot, the VM loop is the most critical part of the code. You should try to avoid executing this if on each turn in the loop.

I would move this inside the instructions that need it. Perhaps you could refactor to an inlined function. Or even code duplication would be OK here IMO, because perf is so important inside the loop.

macournoyer · 2021-10-20T13:44:40Z

ext/liquid_c/vm.c

                if (ip[-1] == OP_FILTER) {
-                    filter_name = *const_ptr++;
+                    filter_name = RARRAY_AREF(constant, 0);
+                    num_args = RARRAY_AREF(constant, 1);


I don't think num_args should be stored in the constants table, it should be in the instruction (like before). The same filter can be called with a different number of args in a given template:

{{ 'a.jpg' | img_tag }} // 0 {{ 'a.jpg' | img_tag: '10x10', preload: true }} // 2

Also, this looks like something a test should have caught. Perhaps a test is missing for ^

Calling the same filter with a different number of arguements should be fine...

I had to store the num_args in the constants_table since I couldn't fit it in the instruction...
I had to come up with a cheeky solution where I store the filter_name and num_args together in the constants_table:
Before:

Insturction: [OP_FILTER][num_args] # 8 + 8 bit Constants: [filter_name] # 8 bit

After:

Insturction: [OP_FILTER][constant_index] # 8 + 16 bit (24 bit limit) Constants: [[filter_name, num_args]]

Aaaah got it! I had the wrong assumption that filter names were reused in the constant table 👍

macournoyer · 2021-10-20T13:54:09Z

ext/liquid_c/vm_assembler.c

        *instructions++ = OP_BUILTIN_FILTER;
        *instructions++ = builtin_index;
+        *instructions++ = arg_count + 1; // include input


Just a note: you'll need to move this back outside the if when moving back arg_count into the instruction.

This will be specifically for built_in filters.
Built in filter instruction:

[OP_FILTER][BUILT_IN_INDEX][ARG_COUNT] # 8 + 8 + 8 bit

Filter instruction:

[OP_FILTER][Constant Index] # 8 + 16 bit (constant = [filter_name, num_args])

macournoyer · 2021-10-20T13:58:43Z

ext/liquid_c/vm_assembler.h

@@ -43,6 +43,7 @@ extern filter_desc_t builtin_filters[];
 typedef struct vm_assembler {
    c_buffer_t instructions;
    c_buffer_t constants;


Do we still need this?

Seems to me it's duplicating data already in constants_table.

ah... good call... I used to store the hash value of the constants, but now I am using constant as key in the constants_table.
Since the keys in st_table are sorted by entries, we can remove constants array. (I will have to double check how st_table works)

I have started to remove the constants, and it is becoming a large PR just by removing it... Let's create a separate PR to remove the constants.
Also, we are storing the VALUE as keys in the constants_table, and those are pointers to actual objects, so we won't be leaving many memory footprints.

actually... I am a bit afraid if JRuby or TruffleRuby will behave the same...

dylanahsmith · 2021-10-21T13:49:54Z

I've added @peterzhu2118 as a reviewer, since this work would ideally fit in nicely with his unmerged work on supporting serializing compiled templates. Similarly, I've added you as a reviewer for his first unmerged PR in that chain of work.

macournoyer

LGTM! 🚀

macournoyer · 2022-02-01T17:41:45Z

ext/liquid_c/vm.c

                if (ip[-1] == OP_FILTER) {
-                    filter_name = *const_ptr++;
+                    filter_name = RARRAY_AREF(constant, 0);
+                    num_args = RARRAY_AREF(constant, 1);


Aaaah got it! I had the wrong assumption that filter names were reused in the constant table 👍

ggmichaelgo force-pushed the mg-const-table branch from 23302b6 to 9d6bdd6 Compare September 2, 2021 03:18

ggmichaelgo force-pushed the mg-const-table branch 7 times, most recently from 0f0f8af to e9fd3c5 Compare September 10, 2021 04:24

ggmichaelgo changed the title ~~store constant address in instruction~~ store constant index in instruction Sep 10, 2021

ggmichaelgo force-pushed the mg-const-table branch 5 times, most recently from 06f440e to a9c841e Compare September 24, 2021 10:51

ggmichaelgo force-pushed the mg-const-table branch 3 times, most recently from 49368f9 to 7f78392 Compare October 13, 2021 00:56

ggmichaelgo requested a review from dylanahsmith October 19, 2021 18:11

ggmichaelgo marked this pull request as ready for review October 19, 2021 18:11

ggmichaelgo requested a review from macournoyer October 19, 2021 18:11

macournoyer requested changes Oct 20, 2021

View reviewed changes

dylanahsmith requested a review from peterzhu2118 October 21, 2021 13:45

ggmichaelgo force-pushed the mg-const-table branch from 2602e6d to 00fc47a Compare November 6, 2021 19:32

ggmichaelgo force-pushed the mg-const-table branch 3 times, most recently from 3df6bfd to 2a64a2c Compare January 16, 2022 21:13

ggmichaelgo changed the base branch from master to exclude-tmp-from-rubocop January 16, 2022 21:13

ggmichaelgo force-pushed the exclude-tmp-from-rubocop branch from 2f3e5e3 to d1a7367 Compare January 17, 2022 17:02

ggmichaelgo changed the base branch from exclude-tmp-from-rubocop to master January 17, 2022 17:57

ggmichaelgo force-pushed the mg-const-table branch from 2a64a2c to 87e6fde Compare February 1, 2022 15:44

macournoyer approved these changes Feb 1, 2022

View reviewed changes

store constant index in instruction

d28a941

ggmichaelgo force-pushed the mg-const-table branch from 87e6fde to d28a941 Compare February 1, 2022 17:50

ggmichaelgo merged commit 44da054 into master Feb 1, 2022

dylanahsmith mentioned this pull request Feb 8, 2022

Replace the moving constant pointer with a constant table #84

Open

shopify-shipit bot had a problem deploying to rubygems February 8, 2022 20:18 Failure

shopify-shipit bot temporarily deployed to rubygems February 8, 2022 20:25 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

store constant index in instruction #155

store constant index in instruction #155

ggmichaelgo commented Sep 2, 2021 •

edited

Loading

macournoyer left a comment

macournoyer Oct 20, 2021

macournoyer Oct 20, 2021

macournoyer Oct 20, 2021

ggmichaelgo Nov 8, 2021

macournoyer Feb 1, 2022

macournoyer Oct 20, 2021

ggmichaelgo Feb 1, 2022

macournoyer Oct 20, 2021

ggmichaelgo Oct 29, 2021

ggmichaelgo Nov 8, 2021

ggmichaelgo Nov 8, 2021

dylanahsmith commented Oct 21, 2021

macournoyer left a comment

macournoyer Feb 1, 2022

store constant index in instruction #155

store constant index in instruction #155

Conversation

ggmichaelgo commented Sep 2, 2021 • edited Loading

What are you trying to accomplish?

What approach did you choose and why?

Performance Improvement on simple rendering

main branch

PR branch

Affect on Performance

macournoyer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dylanahsmith commented Oct 21, 2021

macournoyer left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ggmichaelgo commented Sep 2, 2021 •

edited

Loading