allow extra string after raw tag delimiter #207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to solve?
This PR #200 has broke how Liquid-C parses the raw tag's delimiter with extra string after the tag delimiter.
raw
tag delimiter like this should be allowed, but Liquid-C is raising a syntax error:How are you solving this?
Following the Liquid's
raw
tag delimiter regex, I have updated the Liquid-C's raw tag delimiter to allow extra string after a valid tag delimiter string.match_full_token_possibly_invalid
scans the token string backward, and when it finds a word character after a whitespace character, it will reset its last match.