Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow extra string after raw tag delimiter #207

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

ggmichaelgo
Copy link
Contributor

What are you trying to solve?

This PR #200 has broke how Liquid-C parses the raw tag's delimiter with extra string after the tag delimiter.

raw tag delimiter like this should be allowed, but Liquid-C is raising a syntax error:

{% raw %}
  message
{% endraw this_is_allowed %}

How are you solving this?

Following the Liquid's raw tag delimiter regex, I have updated the Liquid-C's raw tag delimiter to allow extra string after a valid tag delimiter string.

match_full_token_possibly_invalid scans the token string backward, and when it finds a word character after a whitespace character, it will reset its last match.

@ggmichaelgo ggmichaelgo marked this pull request as ready for review September 7, 2023 18:31
@ggmichaelgo ggmichaelgo merged commit 4c87f8c into master Sep 7, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants