Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make tokenizer shift function to be public #209

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

ggmichaelgo
Copy link
Contributor

@ggmichaelgo ggmichaelgo commented Nov 7, 2023

This PR is for Shopify/liquid#1755

In the Liquid PR The comment tag requires to consume the token without creating any child nodes.
The PR will change the comment tag to not parse its body, and allow incomplete Liquid codes as a comment.

@ggmichaelgo ggmichaelgo merged commit 159c6e5 into main Nov 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants