Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "contextualize value before invoking to_liquid" #215

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Revert "contextualize value before invoking to_liquid" #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions ext/liquid_c/context.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,16 +44,12 @@ inline static VALUE value_to_liquid_and_set_context(VALUE value, VALUE context_t
if (klass == rb_cString || klass == rb_cArray || klass == rb_cHash)
return value;

// set value's context before invoking #to_liquid
value = rb_funcall(value, id_to_liquid, 0);

if (rb_respond_to(value, id_set_context))
rb_funcall(value, id_set_context, 1, context_to_set);

VALUE liquid_value = rb_funcall(value, id_to_liquid, 0);

if (liquid_value != value && rb_respond_to(liquid_value, id_set_context))
rb_funcall(liquid_value, id_set_context, 1, context_to_set);

return liquid_value;
return value;
}


Expand Down
Loading