Allow commas to separate for tag attributes (#1658)

For consistency with tags like the `render` tag, where we actually prefer to use commas to separate attributes
Shopify · Nov 29, 2022 · c2c6cb2 · c2c6cb2
1 parent 9ccbf64
commit c2c6cb2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/liquid/tags/for.rb b/lib/liquid/tags/for.rb
@@ -98,11 +98,12 @@ def strict_parse(markup)
       @name     = "#{@variable_name}-#{collection_name}"
       @reversed = p.id?('reversed')
 
-      while p.look(:id) && p.look(:colon, 1)
+      while p.look(:comma) || p.look(:id)
+        p.consume?(:comma)
         unless (attribute = p.id?('limit') || p.id?('offset'))
           raise SyntaxError, options[:locale].t("errors.syntax.for_invalid_attribute")
         end
-        p.consume
+        p.consume(:colon)
         set_attribute(attribute, p.expression)
       end
       p.consume(:end_of_string)

diff --git a/test/integration/tags/for_tag_test.rb b/test/integration/tags/for_tag_test.rb
@@ -103,6 +103,7 @@ def test_limiting
     assert_template_result('1234', '{%for i in array limit:4 %}{{ i }}{%endfor%}', assigns)
     assert_template_result('3456', '{%for i in array limit:4 offset:2 %}{{ i }}{%endfor%}', assigns)
     assert_template_result('3456', '{%for i in array limit: 4 offset: 2 %}{{ i }}{%endfor%}', assigns)
+    assert_template_result('3456', '{%for i in array, limit: 4, offset: 2 %}{{ i }}{%endfor%}', assigns)
   end
 
   def test_limiting_with_invalid_limit