-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix handling of unknown tags in comments #256
Conversation
@@ -4,6 +4,9 @@ def render(context) | |||
'' | |||
end | |||
|
|||
def unknown_tag(tag, markup, tokens) | |||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why this works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because Comment is a subclass of Block. This overwrites Block's unknown_tag
method (which raises).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aah, I see!
Came up with a different solution: Make
Please take another look. |
Nice! 👍 |
Nice clean solution 👍 |
Fix handling of unknown tags in comments
Fixes this:
Please review @sirupsen @dylanahsmith