This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Allow hour12 true to be respected by formatDate #1299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: a beta version of this change is already being used in web
Allows hour12 to be set to true.
Without this change, we were overwriting
hour12
to be false, even when it was set to true. That meant using it to format hours was not working.Before:
After:
Type of change
Checklist