Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Update Koa Proxy Api Versions #1377

Merged
merged 6 commits into from
May 1, 2020
Merged

Update Koa Proxy Api Versions #1377

merged 6 commits into from
May 1, 2020

Conversation

tanema
Copy link

@tanema tanema commented Apr 15, 2020 •
edited
Loading

Description

Updating Api Versions on the koa graphql proxy

Type of change

  • @shopify/koa-shopify-graphql-proxy Major: breaking change

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above

@ismail-syed
Copy link
Contributor

@tanema Do these PR comments still need to be addressed? Happy to re-review and release an updated once these PR comments are addressed.

alexandcote
alexandcote reviewed Apr 27, 2020
View reviewed changes
packages/koa-shopify-graphql-proxy/CHANGELOG.md
<!-- ## [Unreleased] -->
## [Unreleased]

= The `ApiVersion` enum now has an `April20` and `July20` options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The enum already have April20. Maybe we should mention we drop April19

@alexandcote
Copy link
Contributor

I also think it's a breaking change because we drop a deprecated API version.

@tanema
Copy link
Author

tanema commented Apr 27, 2020

Okay but wont that come in another PR?

@alexandcote
Copy link
Contributor

@tanema totally, maybe simply update the PR description so the person who will release the new version will be aware that this is a breaking change 😃

@tanema
Copy link
Author

tanema commented May 1, 2020

Any last reviews? Can I just merge this? I would like to get this merged into the same release as the auth fixes.

ismail-syed
ismail-syed approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@ismail-syed ismail-syed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do a major release once this is in. Please merge once CI is ✅

@tanema
Copy link
Author

tanema commented May 1, 2020

Please wait for this PR #1413

@ismail-syed
Copy link
Contributor

In that case, can you coordinate with @ayronshopify to make sure these PRs go in together? Then I can run a release.

@tanema tanema merged commit 13746db into master May 1, 2020
@tanema tanema deleted the update_graphql_proxy_api_versions branch May 1, 2020 19:22
@ismail-syed ismail-syed temporarily deployed to production May 1, 2020 20:01 Inactive
@ismail-syed ismail-syed temporarily deployed to gem May 7, 2020 18:22 Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexandcote alexandcote alexandcote approved these changes

@ismail-syed ismail-syed ismail-syed approved these changes

@lemonmade lemonmade Awaiting requested review from lemonmade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tanema @ismail-syed @alexandcote