This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR update our build system to support mandatory file extensions. While exploring snowpack and swc, we hit issues where those respective bundlers couldn't parts our
mjs
andesnext
builds. This PR fixes that.This PR fixes the following errors we get when running quilt packages in a webpack 5 react app:
🎩
yarn run clean && yarn run build
to run a fresh buildPeek into a
esm
build to verify the.mjs
extensions (eg.packages/react-html/build/esm/common.mjs
)Peek into an
esnext
build to verify the.esnext
extensions (eg.packages/react-html/build/esnext/common.esnext
)Peek into a
cjs
build to verify the relative.js
extensions (eg.quilt/packages/react-html/build/cjs/common.js
)Checklist