Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Update exclude of tsbuildinfo files #1982

Merged
merged 2 commits into from
Aug 4, 2021
Merged

Update exclude of tsbuildinfo files #1982

merged 2 commits into from
Aug 4, 2021

Conversation

BPScott
Copy link
Member

@BPScott BPScott commented Aug 4, 2021

The lerna v3 to v4 update included a major update to npm-packlist,
which controls what files get packaged into the tar file when
publishing. In npm-packlist v2 *.tsbuildinfo no longer excludes the
build/tsconfig.tsbuildinfo file, we need to give the fuller path to
ensure this file is not uploaded to the npm registry.

See npm/npm-packlist#39

You can prove that the exclude is now working by doing cd packages/address then npx npm-packlist and noting that the build build/tsconfig.tsbuildinfo file is no longer present in the list of returned items

The lerna v3 to v4 update included a major update to `npm-packlist`,
which controls what files get packaged into the tar file when
publishing. In npm-packlist v2 `*.tsbuildconfig` no longer excludes the
`build/tsconfig.tsbuildconfig` file, we need to give the fuller path to
ensure this file is not uploaded to the npm registry.
@BPScott BPScott requested a review from a team August 4, 2021 01:11
@BPScott BPScott force-pushed the remove-tsbuildinfo branch from 62b3f35 to 40ecb30 Compare August 4, 2021 01:13
@BPScott BPScott force-pushed the remove-tsbuildinfo branch from 40ecb30 to 9128cab Compare August 4, 2021 01:14
@BPScott BPScott merged commit 4adf6bd into main Aug 4, 2021
@BPScott BPScott deleted the remove-tsbuildinfo branch August 4, 2021 01:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant