Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Update faker-js/faker to v6 #2231

Merged
merged 1 commit into from
May 19, 2022
Merged

Update faker-js/faker to v6 #2231

merged 1 commit into from
May 19, 2022

Conversation

BPScott
Copy link
Member

@BPScott BPScott commented Apr 6, 2022

Description

Update faker-js/faker to v6 so we don't need to do weird hacks to provide types for the package.

I've updated calls to deprecated behaviour. Searching the CI test logs for 'faker' should result in no deprecation warnings logged to the console.

Type of change

  • graphql-fixtures: major

@BPScott BPScott requested a review from a team as a code owner April 6, 2022 04:18
@BPScott BPScott requested a review from sophschneider April 6, 2022 04:18
@ryanwilsonperkin ryanwilsonperkin dismissed their stale review April 11, 2022 14:05

Noticed issue

Copy link
Member

@ryanwilsonperkin ryanwilsonperkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the latest version is incompatible with Node <14
We support v12 at the moment but it leaves LTS in ~a month, we could wait to ship this or preemptively drop support for 12. Any standard practice that we follow in this case?

@BPScott
Copy link
Member Author

BPScott commented Apr 11, 2022

I'd prefer to explicitly drop support for node 12 by updating engines fields and updating the version we target when building, and then merge this PR.

Considering Shopify internally doesn't support node 14 anymore thanks to everyone using M1s there's an argument to be made for dropping support for v14 too, but that's pretty agressive

@ryanwilsonperkin
Copy link
Member

+1 to dropping node 12, agreed that we should keep node 14 since its LTS

@BPScott
Copy link
Member Author

BPScott commented May 19, 2022

Rebased atop of #2277, which drops support for node 12.

@BPScott BPScott requested a review from ryanwilsonperkin May 19, 2022 16:09
@BPScott BPScott merged commit 491d4af into main May 19, 2022
@BPScott BPScott deleted the faker-update branch May 19, 2022 17:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants