Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Update node-mocks-http #2337

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Update node-mocks-http #2337

merged 3 commits into from
Jun 30, 2022

Conversation

atesgoral
Copy link
Contributor

@atesgoral atesgoral commented Jun 30, 2022

Description

Updates node-mocks-http to pick up a fix to response.getHeaders() (it should be a shallow copy).

eugef/node-mocks-http#217

@atesgoral atesgoral requested a review from a team as a code owner June 30, 2022 21:21
@atesgoral atesgoral requested a review from egjiri June 30, 2022 21:21
Copy link
Member

@BPScott BPScott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the surface a version range bump from ^1.5.8 to ^1.11.0 doesn't sound like a major release. It's not bumping up a major version, and many consumers could already be using node-mocks-http v1.11.0 already, as that version satisfies both the old and new dependency ranges.

On slack you made the argument that the knock-on effects warrant a major bump - consumers could be relying on the broken behaviour present in v1.5.8 and thus produce tests would break in this update, and the update to ^v1.11.0 shall force consumers to address these mistakes - and version bumps that don't apply cleanly should be major version bumps.

I'm happy with that rationale that makes this be a major bump.

@atesgoral
Copy link
Contributor Author

Pushed a dummy commit to unstick the CLA check

@atesgoral atesgoral merged commit 9912c5f into main Jun 30, 2022
@atesgoral atesgoral deleted the update-node-mocks-http branch June 30, 2022 22:36
@github-actions github-actions bot mentioned this pull request Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants