This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
Move @shopify/network to dependencies in react-performance #2819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendo
commented
Aug 9, 2024
brendo
force-pushed
the
chore_fix-react-performance-dep
branch
from
ea7f7a4 to
5b2c18e
Compare
BPScott
approved these changes
Sep 3, 2024
mattkubej
approved these changes
Sep 4, 2024
Merged
|
+1 to inlining - the fewer dependencies the better 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
@shopify/networkpackage is currently listed as adevDependencyfor the@shopify/react-performancepackage. I think this is incorrect as the package is referenced from from performanceReport file.I have moved the package from
devDependencytodependencyto resolve.That said, if we look at the usage of the package in the file, it's simply to reference two constants, so I wonder if we're more comfortable/pragmatic in simply inlining these definitions?
Header.ContentTypequilt/packages/react-performance/src/performance-report.ts
Line 46 in 75ea9fe
Method.Postquilt/packages/react-performance/src/performance-report.ts
Line 44 in 75ea9fe