This repository has been archived by the owner on Oct 1, 2024. It is now read-only.
fix: unknown type in ExecutionResult #2832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattydodd
force-pushed
the
fix/unknown-type-execution-data
branch
from
40835b8
to
e708ea3
Compare
nattydodd
force-pushed
the
fix/unknown-type-execution-data
branch
from
e708ea3
to
3ff2828
Compare
|
/snapit |
|
🫰✨ Thanks @nattydodd! Your snapshot has been published to npm. Test the snapshot by updating your "@shopify/graphql-testing": "0.0.0-snapshot-20240830200301" |
BPScott
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Paired with Natalie on this fix.
Follow up to #2778. When shipping that PR I was testing in checkout-web which uses a forked version of graphql-testing so I never spotted the change in default behaviour for ExecutionResult where in graphql v15 shape of the TData generic allowed an object with the values any but in v16 it that was restricted to unknown, and thus that we need to explicitly state any.
BPScott
approved these changes
Aug 30, 2024
GoodForOneFare
approved these changes
Aug 30, 2024
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Collective (
merchant-to-merchant) team was trying to upgrade our graphql dependency to v16+ and were not able to due to failing typechecks.The change in this PR from the
@shopify/graphql-testinglibrary was causing the typechecks to fail. TheExecutionResulttype from graphql has a new definition is v16, which causes ourfillGraphQLtype to complain with this error:Here is the difference between the types in the two versions which caused the types to complain.
To fix the issue, we had to pass in
<{[key: string]: any}>as the generic type forExecutionResult, inside thegraphql-testingpackageTophatting
I tested this change in the merchant-to-merchant repo and we were able to successfully run our type-checks again. Thanks @BPScott for helping me out on this one 🙏