Fix method completion on explicit self (#1399)

* Fix TextEdit#range for method completion * ensure message_loc is not nil
Shopify · Feb 23, 2024 · 0c21f7a · 0c21f7a
1 parent b1e1092
commit 0c21f7a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lib/ruby_lsp/listeners/completion.rb b/lib/ruby_lsp/listeners/completion.rb
@@ -139,7 +139,7 @@ def build_method_completion(entry, node)
         Interface::CompletionItem.new(
           label: name,
           filter_text: name,
-          text_edit: Interface::TextEdit.new(range: range_from_node(node), new_text: name),
+          text_edit: Interface::TextEdit.new(range: range_from_location(T.must(node.message_loc)), new_text: name),
           kind: Constant::CompletionItemKind::METHOD,
           label_details: Interface::CompletionItemLabelDetails.new(
             detail: "(#{entry.parameters.map(&:decorated_name).join(", ")})",

diff --git a/test/requests/completion_test.rb b/test/requests/completion_test.rb
@@ -495,6 +495,7 @@ def process
     assert_equal(["bar", "baz"], result.map(&:filter_text))
     assert_equal(["bar", "baz"], result.map { |completion| completion.text_edit.new_text })
     assert_equal(["(a, b)", "(c, d)"], result.map { |completion| completion.label_details.detail })
+    assert_equal([9, 9], result.map { |completion| completion.text_edit.range.start.character })
   end
 
   def test_completion_for_methods_named_with_uppercase_characters