Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared fixture repository for our tests #448

Closed
Tracked by #691
vinistock opened this issue Jan 11, 2023 · 0 comments · Fixed by #788
Closed
Tracked by #691

Use shared fixture repository for our tests #448

vinistock opened this issue Jan 11, 2023 · 0 comments · Fixed by #788
Labels
good-first-issue Good for newcomers help-wanted Extra attention is needed pinned This issue or pull request is pinned and won't be marked as stale

Comments

@vinistock
Copy link
Member

vinistock commented Jan 11, 2023

The https://github.com/ruby-syntax-tree/ruby-syntax-fixtures repository includes an extensive list of valid Ruby snippets that is being used to test Syntax Tree and YARP.

The Ruby LSP will still need to have its own fixtures to test things such as code action refactors, where we're not only concerned about the different types of Ruby syntax, but about the behaviour in certain scenarios.

However, it would be nice to also run our requests against that repository of fixtures since it contains many examples of valid Ruby syntax we must support.

For this issue:

  • Add the fixtures repository as a git submodule
  • Change our expectations runner to also execute tests against the submodule fixtures
  • Propose a mechanism for keeping the submodule up to date
@vinistock vinistock added good-first-issue Good for newcomers help-wanted Extra attention is needed labels Apr 6, 2023
@vinistock vinistock added the pinned This issue or pull request is pinned and won't be marked as stale label Jul 20, 2023
vinistock pushed a commit that referenced this issue Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Good for newcomers help-wanted Extra attention is needed pinned This issue or pull request is pinned and won't be marked as stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant