Allow addons to register for filewatching events #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
added
the
server
vinistock
approved these changes
Mar 6, 2024
andyw8
deleted the
andyw8/allow-addons-to-register-for-file-change-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This goes along with Shopify/ruby-lsp-rails#282. We need ruby-lsp to notify the addon when particular files changes.
Implementation
Rather than explicitly registering to receive file change events, addons just need to define a
workspace_did_change_watched_filesmethod.Automated Tests
Included
Manual Tests
Test alongside Shopify/ruby-lsp-rails#282 by making a change to the schema (e.g. add a comment) and watchking the output panel for a reload.