Index all missing global variable nodes #2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
added
the
server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Iteration of #2644
The first PR to index global variables (#2656) focused only on RBS declarations. This covers only partial use cases, as it is possible for a user to define their own global variables.
Implementation
From prism/config.yml, listen to all kinds of global variable writing nodes, and push
GlobalVariableentries into the index.Automated Tests
Added a new file with all kinds of global variable writing.
Manual Tests
Because I have already merged go-to-definition changes for global variables, we can already check that it's working.
Kapture.2024-10-09.at.22.49.02.mp4