Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify symbol search explanation for VS Code #2770

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Oct 24, 2024

No description provided.

@andyw8 andyw8 added the chore Chore task label Oct 24, 2024
@andyw8 andyw8 requested a review from a team as a code owner October 24, 2024 16:53
@@ -10,7 +10,8 @@ module Requests
# informs the editor of all the important symbols, such as classes, variables, and methods, defined in a file. With
# this information, the editor can populate breadcrumbs, file outline and allow for fuzzy symbol searches.
#
# In VS Code, fuzzy symbol search can be accessed by opening the command palette and inserting an `@` symbol.
# In VS Code, symbol search known as 'Go To Symbol in Editor' and can be accessed with Ctrl-Shift-O
# (Cmd-Shift-O on Mac), or by opening the command palette and inserting an `@` symbol.
Copy link
Member

@st0012 st0012 Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still worth maintaining a separate feature usage here? Maybe we can link to the our official doc instead?
(We should keep the LSP related comments above tho)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I think there is probably a lot we can move over. I'm updating it here just in preparation for Ruby Conf hack day issue.

lib/ruby_lsp/requests/document_symbol.rb Outdated Show resolved Hide resolved
Co-authored-by: Vinicius Stock <vinistock@users.noreply.github.com>
@andyw8 andyw8 enabled auto-merge (squash) October 24, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants