-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ruby-lsp-check executable #811
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do we want to run this against ruby-lsp on CI to make sure it doesn't break unnoticed? |
|
vinistock
force-pushed
the
vs/add_lsp_check
branch
from
July 12, 2023 16:01
cce8a1c
to
2ebc609
Compare
Yes, we definitely should! I added a new step. |
andyw8
approved these changes
Jul 12, 2023
vinistock
force-pushed
the
vs/add_lsp_check
branch
from
July 12, 2023 16:13
2ebc609
to
f416093
Compare
st0012
reviewed
Jul 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vinistock
force-pushed
the
vs/add_lsp_check
branch
from
July 12, 2023 17:19
f416093
to
157577b
Compare
Yeah, good point. There's no reason to run it on the entire matrix of Ruby versions either. I split it into a separate action. |
vinistock
force-pushed
the
vs/add_lsp_check
branch
from
July 12, 2023 17:21
157577b
to
27d06f3
Compare
vinistock
force-pushed
the
vs/add_lsp_check
branch
from
July 12, 2023 17:23
27d06f3
to
089e780
Compare
st0012
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The easiest way for us to verify that a release didn't break anything critical is to run our requests against large codebases with numerous examples of syntax.
Having an executable that we can easily invoke to check if everything is fine before releasing should assist us in finding bugs ahead of time.
Implementation
The executable lists every file in the project and then executes one of our automatic requests. In the new listener pattern, it means all automatic requests are executed with it and so any issues with these critical requests will be surfaced.
Manual Tests
/path/to/ruby-lsp-check
in the project