Skip to content

Commit

Permalink
Separate Modular GC CI into it's own workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
eightbitraptor committed Oct 11, 2024
1 parent dc58445 commit 76a691f
Show file tree
Hide file tree
Showing 4 changed files with 377 additions and 56 deletions.
27 changes: 0 additions & 27 deletions .github/workflows/macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,6 @@ jobs:
os: macos-12
- test_task: check
os: macos-13
- test_task: check
gc_name: 'mmtk'
build: 'debug'
shared_gc: true
configure: '--with-shared-gc=/Users/runner/ruby_gc'
os: macos-14
- test_task: check
gc_name: 'mmtk'
build: 'release'
shared_gc: true
configure: '--with-shared-gc=/Users/runner/ruby_gc'
os: macos-14
fail-fast: false

env:
Expand Down Expand Up @@ -105,21 +93,6 @@ jobs:
configure: ${{ matrix.configure }} ${ruby_configure_args}
run: ../src/configure -C --disable-install-doc ${{ env.configure }}

- uses: actions-rust-lang/setup-rust-toolchain@v1
- name: Build MMTK Ruby lib
run: |
cd ../src/gc/mmtk
cargo build ${{ matrix.build != 'debug' && format('--{0}', matrix.build) || format('') }}
echo "RUST_LOG=" >> $GITHUB_ENV
echo "EXCLUDES=../src/test/.excludes-mmtk" >> $GITHUB_ENV
if: ${{ matrix.shared_gc && matrix.gc_name == 'mmtk' }}

- name: Build shared GC
run: |
echo "RUBY_GC_LIBRARY=librubygc.${{ matrix.gc_name }}.dylib" >> $GITHUB_ENV
make shared-gc SHARED_GC=${{ matrix.gc_name }} MMTK_BUILD=${{ matrix.build }}
if: ${{ matrix.shared_gc }}

- run: make prepare-gems
if: ${{ matrix.test_task == 'test-bundled-gems' }}

Expand Down
201 changes: 201 additions & 0 deletions .github/workflows/sharedgc-macos.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,201 @@
name: macOS
on:
push:
paths-ignore:
- 'doc/**'
- '**/man/*'
- '**.md'
- '**.rdoc'
- '**/.document'
- '.*.yml'
pull_request:
# Do not use paths-ignore for required status checks
# https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks
merge_group:

concurrency:
group: ${{ github.workflow }} / ${{ startsWith(github.event_name, 'pull') && github.ref_name || github.sha }}
cancel-in-progress: ${{ startsWith(github.event_name, 'pull') }}

permissions:
contents: read

jobs:
make:
strategy:
matrix:
include:
- test_task: check
gc_name: 'mmtk'
build: 'debug'
configure: '--with-shared-gc=/Users/runner/ruby_gc'
os: macos-14
- test_task: check
gc_name: 'mmtk'
build: 'release'
configure: '--with-shared-gc=/Users/runner/ruby_gc'
os: macos-14
fail-fast: false

env:
GITPULLOPTIONS: --no-tags origin ${{ github.ref }}

runs-on: ${{ matrix.os }}

if: >-
${{!(false
|| contains(github.event.head_commit.message, '[DOC]')
|| contains(github.event.head_commit.message, 'Document')
|| contains(github.event.pull_request.title, '[DOC]')
|| contains(github.event.pull_request.title, 'Document')
|| contains(github.event.pull_request.labels.*.name, 'Documentation')
|| (github.event_name == 'push' && github.event.pull_request.user.login == 'dependabot[bot]')
)}}
steps:
- uses: actions/checkout@d632683dd7b4114ad314bca15554477dd762a938 # v4.2.0
with:
sparse-checkout-cone-mode: false
sparse-checkout: /.github

- name: Install libraries
uses: ./.github/actions/setup/macos

- uses: ./.github/actions/setup/directories
with:
srcdir: src
builddir: build
makeup: true
clean: true
dummy-files: ${{ matrix.test_task == 'check' }}
# Set fetch-depth: 0 so that Launchable can receive commits information.
fetch-depth: 10

- name: make sure that kern.coredump=1
run: |
sysctl -n kern.coredump
sudo sysctl -w kern.coredump=1
sudo chmod -R +rwx /cores/
- name: Delete unused SDKs
# To free up disk space to not run out during the run
run: |
sudo rm -rf ~/.dotnet
sudo rm -rf /Library/Android
sudo rm -rf /Library/Developer/CoreSimulator
continue-on-error: true

- name: Run configure
env:
configure: ${{ matrix.configure }} ${ruby_configure_args}
run: ../src/configure -C --disable-install-doc ${{ env.configure }}

- uses: actions-rust-lang/setup-rust-toolchain@v1
- name: Build MMTK Ruby lib
run: |
cd ../src/gc/mmtk
cargo build ${{ matrix.build != 'debug' && format('--{0}', matrix.build) || format('') }}
echo "RUST_LOG=" >> $GITHUB_ENV
echo "EXCLUDES=../src/test/.excludes-mmtk" >> $GITHUB_ENV
if: ${{ matrix.gc_name == 'mmtk' }}

- name: Build shared GC
run: |
echo "RUBY_GC_LIBRARY=librubygc.${{ matrix.gc_name }}.dylib" >> $GITHUB_ENV
make shared-gc SHARED_GC=${{ matrix.gc_name }} MMTK_BUILD=${{ matrix.build }}
- run: make prepare-gems
if: ${{ matrix.test_task == 'test-bundled-gems' }}

- run: make

- run: |
make golf
case "${{ matrix.configure }}" in
*'--enable-shared'*)
make runnable
./bin/goruby -veh
;;
*)
./goruby -veh
;;
esac
- name: Set test options for skipped tests
run: |
set -x
TESTS="$(echo "${{ matrix.skipped_tests }}" | sed 's| |$$/ -n!/|g;s|^|-n!/|;s|$|$$/|')"
echo "TESTS=${TESTS}" >> $GITHUB_ENV
if: ${{ matrix.test_task == 'check' && matrix.skipped_tests }}

- name: Set up Launchable
uses: ./.github/actions/launchable/setup
with:
os: ${{ matrix.os }}
test-opts: ${{ matrix.test_opts }}
launchable-token: ${{ secrets.LAUNCHABLE_TOKEN }}
builddir: build
srcdir: src
continue-on-error: true

- name: Set extra test options
run: |
echo "TESTS=$TESTS ${{ matrix.test_opts }}" >> $GITHUB_ENV
echo "RUBY_TEST_TIMEOUT_SCALE=10" >> $GITHUB_ENV # With --repeat-count=2, flaky test by timeout occurs frequently for some reason
if: matrix.test_opts

- name: make ${{ matrix.test_task }}
run: |
ulimit -c unlimited
make -s ${{ matrix.test_task }} ${TESTS:+TESTS="$TESTS"}
timeout-minutes: 60
env:
RUBY_TESTOPTS: '-q --tty=no'
TEST_BUNDLED_GEMS_ALLOW_FAILURES: 'typeprof'
PRECHECK_BUNDLED_GEMS: 'no'

- name: make skipped tests
run: |
make -s test-all TESTS="${TESTS//-n!\//-n/}"
env:
GNUMAKEFLAGS: ''
RUBY_TESTOPTS: '-v --tty=no'
PRECHECK_BUNDLED_GEMS: 'no'
if: ${{ matrix.test_task == 'check' && matrix.skipped_tests }}
continue-on-error: ${{ matrix.continue-on-skipped_tests || false }}

- uses: ./.github/actions/slack
with:
label: ${{ matrix.os }} / ${{ matrix.test_task }}
SLACK_WEBHOOK_URL: ${{ secrets.SIMPLER_ALERTS_URL }} # ruby-lang slack: ruby/simpler-alerts-bot
if: ${{ failure() }}

- name: Resolve job ID
id: job_id
uses: actions/github-script@main
env:
matrix: ${{ toJson(matrix) }}
with:
script: |
const { data: workflow_run } = await github.rest.actions.listJobsForWorkflowRun({
owner: context.repo.owner,
repo: context.repo.repo,
run_id: context.runId
});
const matrix = JSON.parse(process.env.matrix);
const job_name = `${context.job}${matrix ? ` (${Object.values(matrix).join(", ")})` : ""}`;
return workflow_run.jobs.find((job) => job.name === job_name).id;
result:
if: ${{ always() }}
name: ${{ github.workflow }} result
runs-on: macos-latest
needs: [make]
steps:
- run: exit 1
working-directory:
if: ${{ contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled') }}

defaults:
run:
working-directory: build
Loading

0 comments on commit 76a691f

Please sign in to comment.