Threshold 1 should compile immediately

Shopify · Sep 28, 2023 · 9ffe61b · 9ffe61b
1 parent 4007b34
commit 9ffe61b
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/yjit/src/yjit.rs b/yjit/src/yjit.rs
@@ -57,7 +57,12 @@ pub extern "C" fn rb_yjit_threshold_hit(iseq: IseqPtr, total_calls: u64) -> bool
     unsafe { TOTAL_ENTRY_HITS += 1; }
 
     if total_calls >= call_threshold {
+        // We expect threshold 1 to compile everything immediately
+        if call_threshold == 1 {
+            return true;
+        }
 
+        // If we are at the threshold
         if total_calls == call_threshold {
             let payload = get_or_create_iseq_payload(iseq);
             let call_count = unsafe { TOTAL_ENTRY_HITS };
@@ -71,6 +76,7 @@ pub extern "C" fn rb_yjit_threshold_hit(iseq: IseqPtr, total_calls: u64) -> bool
             let call_count = unsafe { TOTAL_ENTRY_HITS };
             let num_calls = call_count - payload.call_count_at_threshold;
 
+            // Reject ISEQs that don't get called often enough
             if num_calls > get_option!(cold_threshold) as u64 {
                 incr_counter!(iseq_entry_cold);
                 return false;