[sasl] use a SCRAM client for each connection #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
mrsinham
force-pushed
the
sasl_client_datarace
branch
from
d8ed0fb to
f87f2e8
Compare
|
Hi ! I just signed the CLA, thx |
mrsinham
force-pushed
the
sasl_client_datarace
branch
from
f87f2e8 to
687e680
Compare
varun06
reviewed
Apr 9, 2019
config.go
Outdated
| @@ -503,8 +503,8 @@ func (c *Config) Validate() error { | |||
| if c.Net.SASL.Password == "" { | |||
| return ConfigurationError("Net.SASL.Password must not be empty when SASL is enabled") | |||
| } | |||
| if c.Net.SASL.SCRAMClient == nil { | |||
| return ConfigurationError("A SCRAMClient instance must be provided to Net.SASL.SCRAMClient") | |||
| if c.Net.SASL.SCRAMClientGenerator == nil || c.Net.SASL.SCRAMClientGenerator() == nil { | |||
There was a problem hiding this comment.
It's kinda protecting the user against himself but it doesn't hurt IMHO.
There was a problem hiding this comment.
I removed the second test as it is not very useful
mrsinham
force-pushed
the
sasl_client_datarace
branch
from
687e680 to
8745624
Compare
iyedbennour
reviewed
Apr 9, 2019
config_test.go
Outdated
| cfg.Net.SASL.User = "user" | ||
| cfg.Net.SASL.Password = "stong_password" | ||
| }, | ||
| "A SCRAMClient instance must be provided to Net.SASL.SCRAMClient"}, | ||
| "A SCRAMClientGenerator closure must be provided to Net.SASL.SCRAMClientGenerator"}, |
There was a problem hiding this comment.
I suggest changing closure to function
iyedbennour
reviewed
Apr 9, 2019
config.go
Outdated
| // client used to perform the SCRAM exchange with the server. | ||
| SCRAMClient SCRAMClient | ||
| SCRAMClientGenerator func() SCRAMClient |
There was a problem hiding this comment.
SCRAMClientGeneratorFunc
mrsinham
force-pushed
the
sasl_client_datarace
branch
from
8745624 to
5722d69
Compare
varun06
approved these changes
Apr 15, 2019
|
Hello guys ! A dot release with this code would be awesome. I am happy to help if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As sarama can connect to multiple brokers as the same time, the scram client must be different for each connection as it uses steps to connect via sasl. This avoids the auth mechanism to use the same scram client on connection that have different states.
Symptoms example:
2019/03/29 09:24:18 kafka: error while consuming *****/6: kafka server: Request is not valid given the current SASL state.