Scram

[squ1d123]

No description provided.

[squ1d123]

This will address issue #98

[fritchie]

thx, looking forward to this

[gramer]

I've tried it, but the connection is very unstable.

./kafka_exporter --kafka.server=xxxx:9092 --sasl.enabled --sasl.username=xxx --sasl.password="xxxx" --sasl.mechanism="scram-sha256" --kafka.version=2.1.0 --log.enable-sarama

The following logs are often visible and as a result collecting often fails.

[sarama] 2019/04/28 11:11:01 SASL authentication failed not enough fields in first server message [sarama] 2019/04/28 11:11:01 Closed connection to broker xxxx:9092 ERRO[0079] Cannot get current offset of topic kafka.qili-local.1 partition 0: not enough fields in first server message source="kafka_exporter.go:290" ERRO[0079] Cannot get current offset of topic kafka.test2.1 partition 0: not enough fields in first server message source="kafka_exporter.go:290" ERRO[0079] Cannot get current offset of topic message2_api.app_push_dispatcher.v1 partition 0: not enough fields in first server message source="kafka_exporter.go:290" ERRO[0079] Cannot get current offset of topic kafka.test-2.1 partition 0: not enough fields in first server message source="kafka_exporter.go:290" [sarama] 2019/04/28 11:11:01 SASL authentication failed error parsing 'r=MrRT9lQ8Cw8/uc6AKQUfWraadsOTD+Wt14hvfqsbdg5v4ebqhclog4jojs' for field 'e' [sarama] 2019/04/28 11:11:01 Closed connection to broker xxx:9092 [sarama] 2019/04/28 11:11:01 client/metadata fetching metadata for [message2_api.text_dispatcher_response.v1] from broker xxx:9092 ERRO[0079] Cannot get current offset of topic kafka.test.1 partition 0: error parsing 'r=MrRT9lQ8Cw8/uc6AKQUfWraadsOTD+Wt14hvfqsbdg5v4ebqhclog4jojs' for field 'e' source="kafka_exporter.go:290"

[robholland]

This has worked great for us, no connection issues.

[gramer]

After upgrading sarama, no connection issue. refer to below commits
IBM/sarama#1349

[squ1d123]

Updated pull request to use latest sarama as referred to by @gramer

[peimanja]

Any update on this one?

[muffin87]

It would be wonderfull if this feature would be added. All my Kafka clusters need to use SCRAM.

[rajivchirania]

@squ1d123 How can i use your branch..I get the below error

Failed to pull image "squ1d123/kafka_exporter:latest": rpc error: code = Unknown desc = Error response from daemon: pull access denied for squ1d123/kafka_exporter, repository does not exist or may require 'docker login'

[fcosta-td]

Is something missing from this PR to prevent it from being merged?

[paulojmdias]

Can someone merge this? It works and we need that.

[Neustradamus]

Any news?

[leonrado]

Merge this will be great

[gabrielmuras]

Any news? Merging will be very helpful for us.

[jagdeepgithub]

Yes it would be helpful if we can merge this change. Thanks!

[Fanduzi]

@danielqsj
合并分支吧, 现在很多公司都开SCRAM认证了. 这么多老外等着呢

[danielqsj]

Thanks @squ1d123

/lgtm

[Neustradamus]

@squ1d123, @Fanduzi, @danielqsj: Thanks a lot after one year for this PR!

[jagdeepgithub]

Any eta on when this will be released?

[koflTS]

The merged commit does not build on Travis. I also have a need for this feature. Hopefully someone finds the error soon.